Add methods for getting file data from the vfs #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the combine byte array methood should probably be moved somewhere else or changed to something for blocks if you'd prefer the data be returned as a block, i feel that'll probably be the most contentious bit of this PR |
wannkunstbeikor
requested changes
Aug 8, 2024
wannkunstbeikor
requested changes
Aug 11, 2024
wannkunstbeikor
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only things to really note are that i had to add something to let the method for getting the file data know what encryption to use, probably better like this anyway
and that obviously i can't get any oodle slices since we don't support that right now